Page MenuHomePhabricator
Differential D12107

[test] Throw error instead of segfaulting in failure scenario
ClosedPublic
Actions

Authored by PiRK on Sep 30 2022, 15:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6b093d9d1299: [test] Throw error instead of segfaulting in failure scenario
Summary

If the miner code is faulty and does not include any transactions in a block,
the code segfaults when it tries to access block transactions. Instead, add a
check that safely aborts the process.

This is a backport of core#21121 [2/4]
https://github.com/bitcoin/bitcoin/pull/21121/commits/a2d908e1daa1d1be74568bd7d1d04b724da7d79c

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2022, 15:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2022, 15:26
PiRK requested review of this revision.Sep 30 2022, 15:26
teamcity edited the summary of this revision. (Show Details)Sep 30 2022, 15:26
Harbormaster completed remote builds in B20271: Diff 35324.Sep 30 2022, 15:59
Fabien requested changes to this revision.Sep 30 2022, 16:11
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/miner_tests.cpp
148 ↗(On Diff #35324)

size_t is unsigned, compare with 4u to avoid a "comparison of integers of different signs" warning (from the PR comments)

187 ↗(On Diff #35324)

dito

226 ↗(On Diff #35324)

dito

This revision now requires changes to proceed.Sep 30 2022, 16:11
PiRK updated this revision to Diff 35329.Sep 30 2022, 16:26

avoid comparison of integer and unsigned size_t

Harbormaster completed remote builds in B20276: Diff 35329.Sep 30 2022, 16:40
Fabien accepted this revision.Sep 30 2022, 18:25
This revision is now accepted and ready to land.Sep 30 2022, 18:25
PiRK updated this revision to Diff 35354.Oct 3 2022, 16:21

rebase

Harbormaster completed remote builds in B20291: Diff 35354.Oct 3 2022, 16:22
teamcity added a comment.Oct 3 2022, 16:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:24
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:24
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 35384.Oct 4 2022, 04:22

rebase

Harbormaster completed remote builds in B20317: Diff 35384.Oct 4 2022, 04:23
teamcity added a comment.Oct 4 2022, 04:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 04:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 04:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 04:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 04:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 04:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:27
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 07:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 35386.Oct 4 2022, 07:38

rebase on latest master

Harbormaster completed remote builds in B20319: Diff 35386.Oct 4 2022, 07:58
Closed by commit rABC6b093d9d1299: [test] Throw error instead of segfaulting in failure scenario (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyOct 4 2022, 14:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6b093d9d1299: [test] Throw error instead of segfaulting in failure scenario.

Revision Contents
Changeset List

PathSize
src/
test/
3 lines

Diff 35402

View Options

src/test/miner_tests.cpp

Loading...