Improve clarity of makeseeds and increase max ipv6 ASNs
ClosedPublic
Actions

Authored by sdulfari on Oct 4 2022, 22:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Backport of core#24818

This patch increases the number of ipv6 seeds from 2 to 10 per ASN and
increases MIN_BLOCKS to 730000.

Most of the refactors are not big improvements in clarity but it does bring
our code more inline with Bitcoin Core.

Test Plan

python3 makeseeds.py < seeds_main.txt > nodes_main.txt
python3 makeseeds.py < seeds_test.txt > nodes_test.txt
git diff

Diff should be more additions than removals and retain most of the old entries.

Repository

rABC Bitcoin ABC

Branch

pr24818

Lint

Lint Passed

Unit

No Test Coverage

Build Status

sdulfari requested review of this revision.Oct 4 2022, 22:05

sdulfari edited the summary of this revision. (Show Details)

Fabien requested changes to this revision.Oct 5 2022, 07:42

Fabien added a subscriber: Fabien.

Fabien added inline comments.

contrib/seeds/makeseeds.py
18 ↗	(On Diff #35419)	I think we should bump the ipv4 as well. There is little to no drawback doing so and with avalanche it's not rare that a lot of very good peers are in the same network/DC. Can be its own diff for the sake of keeping the backport clean.
22 ↗	(On Diff #35419)	760000