Page MenuHomePhabricator
Differential D12184

Refactor ProcessNewBlock calls to reduce code duplication and take a CBlock reference
ClosedPublic
Actions

Authored by PiRK on Oct 10 2022, 08:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC79177102e678: Refactor ProcessNewBlock calls to reduce code duplication and take a CBlock…
Summary

core#21713

Refactor ProcessNewBlock to reduce code duplication

core#22106

validation: change ProcessNewBlock() to take a CBlock reference

Update ProcessNewBlock arguments to newer style.

net: cleanup newly added PeerManagerImpl::ProcessBlock

Addresses some post-merge comments.

This is a backport of core#21713 and core#22106

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 10 2022, 08:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 08:17
PiRK requested review of this revision.Oct 10 2022, 08:17
teamcity edited the summary of this revision. (Show Details)Oct 10 2022, 08:17
PiRK edited the summary of this revision. (Show Details)Oct 10 2022, 08:20
PiRK updated this revision to Diff 35546.Oct 10 2022, 08:24

fix accidental file mode modification (chmod -x src/net_processing.cpp)

I'm not sure how this happened. Maybe an accidental IDE shortcut activation.

Harbormaster completed remote builds in B20415: Diff 35543.Oct 10 2022, 08:31
Harbormaster completed remote builds in B20416: Diff 35546.Oct 10 2022, 09:07
Fabien accepted this revision.Oct 10 2022, 12:17
This revision is now accepted and ready to land.Oct 10 2022, 12:17
Closed by commit rABC79177102e678: Refactor ProcessNewBlock calls to reduce code duplication and take a CBlock… (authored by R E Broadley <rebroad+github@gmail.com>, committed by PiRK). · Explain WhyOct 10 2022, 13:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC79177102e678: Refactor ProcessNewBlock calls to reduce code duplication and take a CBlock….

Revision Contents
Changeset List

PathSize
src/
50 lines
14 lines
16 lines

Diff 35552

View Options

src/net_processing.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...