[Cashtab] Create adjustTokenQtyForDecimals function
AbandonedPublic
Actions

Authored by kieran709 on Oct 10 2022, 13:28.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Related to T2690. Created a function, adjustTokenQtyForDecimals, which handles adjusting the token quantity for decimals throughout the app. Replaced logic throughout the app that adjusted token quantity for decimals with the new function, and added unit tests.

Test Plan

cd web/cashtab && npm start
npm test - all tests pass

Diff Detail

Repository

rABC Bitcoin ABC

Branch

adjust-token-decimals-function

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20420
Build 40513: Build Diff	cashtab-tests
Build 40512: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 10 2022, 13:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 13:28

kieran709 requested review of this revision.Oct 10 2022, 13:28

Harbormaster completed remote builds in B20420: Diff 35554.Oct 10 2022, 13:32

In retrospect, I don't think this adding value by simplifying the app and standardizing this application. It's happening in a few places as a one-liner function, which is okay. Go ahead and abandon this.

This revision now requires changes to proceed.Oct 11 2022, 16:24

kieran709 abandoned this revision.Oct 18 2022, 14:18