Paths

Table of Contentst

Differential D12229

validation: make CChainState::m_mempool optional
ClosedPublic
Actions

Authored by Fabien on Oct 12 2022, 19:30.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCa1b2f0d96556: validation: make CChainState::m_mempool optional

Summary

Since we now have multiple chainstate objects, only one of them is active at any given
time. An active chainstate has a mempool, but there's no point to others having one.

Partial backport of core#22415:
https://github.com/bitcoin/bitcoin/pull/22415/commits/617661703ac29e0744f21de74501d033fdc53ff6#diff-1b75f2d827c545064a075d3a1a1414ddcf11edef153a1bd0e103adcc80c8e219

Also includes a missing null pointer check from D9780 in GetCoinsCacheSizeState().

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 12 2022, 19:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 19:30

Fabien requested review of this revision.Oct 12 2022, 19:30

teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 19:30

Fabien added a child revision: D12230: refactor: no mempool arg to GetCoinsCacheSizeState.Oct 12 2022, 19:31

Harbormaster completed remote builds in B20474: Diff 35630.Oct 12 2022, 19:44

sdulfari accepted this revision.Oct 12 2022, 20:39

This revision is now accepted and ready to land.Oct 12 2022, 20:39

Closed by commit rABCa1b2f0d96556: validation: make CChainState::m_mempool optional (authored by Fabien). · Explain WhyOct 13 2022, 08:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa1b2f0d96556: validation: make CChainState::m_mempool optional.

Fabien mentioned this in D12237: Fix the chronikbridge test.Oct 13 2022, 09:05

Fabien mentioned this in rABC042ee436d067: Fix the chronikbridge test.Oct 13 2022, 09:12

Revision Contents
Changeset List

Path

Size

src/

init.cpp

2 lines

test/

util/

setup_common.cpp

2 lines

validation_chainstate_tests.cpp

2 lines

validation_chainstatemanager_tests.cpp

8 lines

validation_flush_tests.cpp

2 lines

validation.h

21 lines

validation.cpp

146 lines

Diff 35637

View Options

src/init.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/validation_chainstate_tests.cpp

View Options

src/test/validation_chainstatemanager_tests.cpp

View Options

src/test/validation_flush_tests.cpp

View Options

src/validation.h

View Options

validation: make CChainState::m_mempool optionalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35637

src/init.cpp

src/test/util/setup_common.cpp

src/test/validation_chainstate_tests.cpp

src/test/validation_chainstatemanager_tests.cpp

src/test/validation_flush_tests.cpp

src/validation.h

src/validation.cpp

validation: make CChainState::m_mempool optional
ClosedPublic
Actions

Revision Contents
Changeset List