Page MenuHomePhabricator

addrman: Fix format string in deserialize error
ClosedPublic

Authored by Fabien on Oct 18 2022, 13:48.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC47205cfc4e5c: addrman: Fix format string in deserialize error
Summary
The format string is evaluated differently on modern compilers (clang 10 and later, as well as gcc 10 and later).
Work around the behaviour change in compilers by pinning the underlying type of the format arguments.
Can be tested by observing a failing test when running against master compiled with clang 10 or gcc 10 (or later).

Backport of core#22879.

Test Plan

With Clang and GCC:

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable