HomePhabricator

addrman: Fix format string in deserialize error

Description

addrman: Fix format string in deserialize error

Summary:

The format string is evaluated differently on modern compilers (clang 10 and later, as well as gcc 10 and later).
Work around the behaviour change in compilers by pinning the underlying type of the format arguments.
Can be tested by observing a failing test when running against master compiled with clang 10 or gcc 10 (or later).

Backport of core#22879.

Test Plan:
With Clang and GCC:

ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12295

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Sep 3 2021, 12:48
FabienCommitted on Oct 18 2022, 20:16
FabienPushed on Oct 18 2022, 20:16
Reviewer
Restricted Project
Differential Revision
D12295: addrman: Fix format string in deserialize error
Parents
rABC9a1305b07178: [addrman] Make m_asmap private
Branches
Unknown
Tags
Unknown