Differential D12312

rpc, test: addpeeraddress test coverage, code simplify/constness
ClosedPublic
Actions

Authored by Fabien on Oct 19 2022, 16:40.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCfb3145c23bb7: rpc, test: addpeeraddress test coverage, code simplify/constness

Summary

- Add functional test coverage for rpc addpeeraddress
- Simplify addpeeraddress and improve code constness

Backport of core#22043.

Test Plan

./test/functional/test_runner.py rpc_net

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 19 2022, 16:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2022, 16:40

Fabien requested review of this revision.Oct 19 2022, 16:40

teamcity edited the summary of this revision. (Show Details)Oct 19 2022, 16:40

Harbormaster completed remote builds in B20612: Diff 35850.Oct 19 2022, 16:51

Fabien added a child revision: D12313: test: add addpeeraddress "tried", test addrman checks on restart with asmap.Oct 19 2022, 17:00

sdulfari accepted this revision.Oct 19 2022, 23:18

This revision is now accepted and ready to land.Oct 19 2022, 23:18

Closed by commit rABCfb3145c23bb7: rpc, test: addpeeraddress test coverage, code simplify/constness (authored by Jon Atack <jon@atack.com>, committed by Fabien). · Explain WhyOct 20 2022, 07:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfb3145c23bb7: rpc, test: addpeeraddress test coverage, code simplify/constness.

Revision Contents
Changeset List

Path

Size

src/

rpc/

net.cpp

32 lines

test/

functional/

rpc_net.py

36 lines

Diff 35872

View Options

src/rpc/net.cpp