Page MenuHomePhabricator
Differential D12347

[validation/refactor] store precomputed txdata in workspace
ClosedPublic
Actions

Authored by PiRK on Oct 21 2022, 07:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7afb34933161: [validation/refactor] store precomputed txdata in workspace
Summary

We want to be able to re-use the precomputed transaction data between
PolicyScriptChecks and ConsensusScriptChecks in
AcceptMultipleTransactions.

For Bitcoin ABC, the PolicyScriptChecks code is part of PreChecks.

D8203 duplicated the initialization of the PrecomputedTransactionData. This patch changes it to be computed only once, and only if the cheap pre-checks are successful.

This is a partial backport of core#23381
https://github.com/bitcoin/bitcoin/pull/23381/commits/cbb3598b5ce2bea58a8cb1ad2167d7d1d079acf7

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 21 2022, 07:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2022, 07:49
PiRK requested review of this revision.Oct 21 2022, 07:49
teamcity edited the summary of this revision. (Show Details)Oct 21 2022, 07:49
PiRK edited the summary of this revision. (Show Details)Oct 21 2022, 07:49
Fabien requested changes to this revision.Oct 21 2022, 07:58
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
405 ↗(On Diff #35905)

Nope

731 ↗(On Diff #35905)

Nit: as per source material

This revision now requires changes to proceed.Oct 21 2022, 07:58
Harbormaster completed remote builds in B20658: Diff 35905.Oct 21 2022, 08:04
PiRK updated this revision to Diff 35926.Oct 21 2022, 09:15
PiRK edited the summary of this revision. (Show Details)

skip D12341 & nit

PiRK edited the summary of this revision. (Show Details)Oct 21 2022, 09:16
PiRK removed a parent revision: D12341: validation: don't compute txdata twice.
PiRK mentioned this in D12341: validation: don't compute txdata twice.
Harbormaster completed remote builds in B20661: Diff 35926.Oct 21 2022, 09:53
Fabien accepted this revision.Oct 21 2022, 10:12
This revision is now accepted and ready to land.Oct 21 2022, 10:12
Closed by commit rABC7afb34933161: [validation/refactor] store precomputed txdata in workspace (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyOct 21 2022, 12:11
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7afb34933161: [validation/refactor] store precomputed txdata in workspace.
PiRK mentioned this in D12353: Deduplicate call to PreChecks in AcceptSingleTransaction.Oct 21 2022, 13:25
PiRK mentioned this in rABC512168c24f94: Deduplicate call to PreChecks in AcceptSingleTransaction.Oct 21 2022, 14:03

Revision Contents
Changeset List

PathSize
src/
32 lines

Diff 35931

View Options

src/validation.cpp

Loading...