Page MenuHomePhabricator
Differential D12351

[validation/rpc] cache + use vsize calculated in PreChecks
ClosedPublic
Actions

Authored by PiRK on Oct 21 2022, 13:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7597e8cfa37d: [validation/rpc] cache + use vsize calculated in PreChecks
Summary

This is not only cleaner but also helps make sure we are always using
the virtual size measure that includes the sigop weight heuristic (which
is the vsize the mempool would return).

This is a b)rtial ackport of core#23381
https://github.com/bitcoin/bitcoin/pull/23381/commits/36a8441912bf84b4da9c74826dcd42533d8abaaa

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 21 2022, 13:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2022, 13:02
PiRK requested review of this revision.Oct 21 2022, 13:02
teamcity edited the summary of this revision. (Show Details)Oct 21 2022, 13:02
Harbormaster completed remote builds in B20665: Diff 35932.Oct 21 2022, 13:16
Fabien requested changes to this revision.Oct 21 2022, 16:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
400 ↗(On Diff #35932)

dito

src/validation.h
261 ↗(On Diff #35932)

That's wrong

This revision now requires changes to proceed.Oct 21 2022, 16:17
PiRK updated this revision to Diff 35950.Oct 22 2022, 09:17

sigops -> sigchecks

Harbormaster completed remote builds in B20678: Diff 35950.Oct 22 2022, 09:32
Fabien accepted this revision.Oct 24 2022, 07:56
This revision is now accepted and ready to land.Oct 24 2022, 07:56
Closed by commit rABC7597e8cfa37d: [validation/rpc] cache + use vsize calculated in PreChecks (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyOct 24 2022, 12:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7597e8cfa37d: [validation/rpc] cache + use vsize calculated in PreChecks.

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
13 lines
17 lines

Diff 35959

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...