Page MenuHomePhabricator
Differential D12405

avalanche: add 'finalized' field to getblockstats
AbandonedPublic
Actions

Authored by majcosta on Nov 1 2022, 02:40.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Summary

as title

seems useful and inexpensive

Test Plan

ninja all check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Nov 1 2022, 02:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2022, 02:40
majcosta requested review of this revision.Nov 1 2022, 02:40
Harbormaster completed remote builds in B20781: Diff 36095.Nov 1 2022, 02:57
sdulfari requested changes to this revision.Nov 1 2022, 23:42
sdulfari added a subscriber: sdulfari.

What is the use case for adding this field in addition to isfinalblock RPC?

This revision now requires changes to proceed.Nov 1 2022, 23:42
majcosta abandoned this revision.Nov 2 2022, 00:06

Yea, after pushing this, "blockstats" does not seem to be the right place to get Avalanche finalization status as well. Abandoning.

Revision Contents
Changeset List

PathSize
src/
rpc/
5 lines
test/
functional/
data/
9 lines

Diff 36095

View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/data/rpc_getblockstats.json

Loading...