Differential D1243

[macOS] remove Growl support, remove unused code
ClosedPublic
Actions

Authored by kyuupichan on Apr 5 2018, 04:42.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING427bef944508: [macOS] remove Growl support, remove unused code
rABC427bef944508: [macOS] remove Growl support, remove unused code

Summary

Backport Core PR 11268: [macOS] remove Growl support, remove unused code
https://github.com/bitcoin/bitcoin/pull/11268

f151f5f50 [macOS] remove Growl support, remove unused code (Jonas Schnelli)

Pull request description:

  There is no longer a reason to support Growl.
  A) It went to pay-ware since a couple of years
  B) Since OSX 10.8, the operating system has its own modal notification options (Notification Center).

  This PR removes support for Growl.
  OSX notification centre is still supported after this PR.

Test Plan

make check

confirm Qt GUI runs fine on MacOSX

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kyuupichan created this revision.Apr 5 2018, 04:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2018, 04:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel edited the summary of this revision. (Show Details)Apr 5 2018, 04:46

schancel edited the test plan for this revision. (Show Details)

schancel accepted this revision.Apr 5 2018, 04:50

This revision is now accepted and ready to land.Apr 5 2018, 04:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2235: Diff 3388.Apr 5 2018, 05:21

Closed by commit rABC427bef944508: [macOS] remove Growl support, remove unused code (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by kyuupichan). · Explain WhyApr 5 2018, 05:22

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

macnotificationhandler.h

8 lines

macnotificationhandler.mm

14 lines

4 lines

notificator.cpp

86 lines

Diff 3389

src/qt/macnotificationhandler.h

Loading...

src/qt/macnotificationhandler.mm

Loading...

src/qt/notificator.h

Loading...

src/qt/notificator.cpp

Loading...