test: run mempool_reorg.py even with wallet disabled
ClosedPublic
Actions

Authored by Fabien on Nov 8 2022, 13:09.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC25936772b12a: test: run mempool_reorg.py even with wallet disabled

Summary

- run mempool_reorg.py even when the wallet is not compiled
- add `locktime` argument to `create_self_transfer` and `send_self_transfer`
- use more logs instead of comments

Backport of core#21178.

Depends on D12434.

Note that in the source material the locktime is not passed down from
send_self_transfer to create_self_transfer which is an obvious oversight.
This is silently fixed in core#22210 but I also fixed it in this diff.

Test Plan

./test/functional/test_runner.py mempool_reorg

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 8 2022, 13:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2022, 13:09

Fabien requested review of this revision.Nov 8 2022, 13:09

teamcity edited the summary of this revision. (Show Details)Nov 8 2022, 13:09

Harbormaster completed remote builds in B20828: Diff 36166.Nov 8 2022, 13:21

Fabien added a child revision: D12436: test: Run feature_cltv with MiniWallet.Nov 8 2022, 16:42

sdulfari requested changes to this revision.Nov 8 2022, 18:09

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

test/functional/test_framework/wallet.py
85 ↗	(On Diff #36166)	Any reason to not use `**kwargs` here like in https://github.com/bitcoin/bitcoin/pull/22210/files#diff-7932a60a9127fd22d10d367526fd7b987f9647ce017595f8b1af5c32d5db0083 ?