[avalanche] make the mocktime increase monotonically
ClosedPublic
Actions

Authored by PiRK on Nov 17 2022, 12:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6477e6a9c6c2: [avalanche] make the mocktime increase monotonically

Summary

The logic was wrong in this test, and the mocktime was set back in time. MAX_ADDR_SEND_DELAY is larger than GETAVAADDR_INTERVAL, so it is not necessary to change the mocktime after already moving the time far enough after the first GETAVAADDR.

I added an assertion to make sure we will get a meaningful error if GETAVAADDR_INTERVAL ever becomes larger than MAX_ADDR_SEND_DELAY.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 17 2022, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2022, 12:49

PiRK requested review of this revision.Nov 17 2022, 12:49

Harbormaster completed remote builds in B20968: Diff 36373.Nov 17 2022, 13:03

Fabien retitled this revision from [test] make the mocktime increase monotonically to [avalanche] make the mocktime increase monotonically.Nov 17 2022, 13:09

Fabien accepted this revision.Nov 17 2022, 13:14

This revision is now accepted and ready to land.Nov 17 2022, 13:14

Closed by commit rABC6477e6a9c6c2: [avalanche] make the mocktime increase monotonically (authored by PiRK). · Explain WhyNov 17 2022, 13:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6477e6a9c6c2: [avalanche] make the mocktime increase monotonically.