Page MenuHomePhabricator

refactor: Remove unused validation includes
ClosedPublic

Authored by PiRK on Nov 30 2022, 10:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCef1cd9fab1a2: refactor: Remove unused validation includes
Summary

Unused includes will cause needless recompilation when headers are changed. Also, they pretend there are dependencies that don't exist.

Fix both by removing them.

This is a backport of core#23044

Notes:

  • the CScriptCheck forward declaration is needed by Bitcoin ABC, because the CheckScriptInputs function is declared in validation.h rather than validation.cpp
  • I removed also two unused includes in validation.cpp flagged by my IDE
Test Plan

ninja all check-all bitcoin-fuzzers bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable