Page MenuHomePhabricator

[Cashtab] Update undefined checks
AbandonedPublic

Authored by bytesofman on Dec 6 2022, 06:15.

Details

Reviewers
kieran709
Group Reviewers
Restricted Project
Summary

Related to T2835. Per instructions in the task, all checks for someVariable === undefined, or !== undefined, have been replaced with typeof someVariable === 'undefined', and !== 'undefined'.

Test Plan

cd web/cashtab
npm test
observe that all tests pass
grep -r '=== undefined' src/ should return nothing
grep -r '!== undefined' src/ should return nothing

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replace-undefined
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21394
Build 42438: Build Diffcashtab-tests
Build 42437: arc lint + arc unit

Event Timeline

bytesofman abandoned this revision.
bytesofman added a reviewer: kieran709.

Could be implemented later on in linter. Low priority.