Page MenuHomePhabricator
Differential D1278

[secp256k1] Fix bench_internal build
ClosedPublic
Actions

Authored by deadalnix on Apr 11 2018, 23:01.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING77507ac86f97: [secp256k1] Fix bench_internal build
rABC77507ac86f97: [secp256k1] Fix bench_internal build
Summary

bench_internal try to include hash.h when the multiset module is enabled. However, this file is not in the include path, so we add it there.

Test Plan
make -C src/secp256k1 bench_internal

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 11 2018, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2018, 23:01
schancel requested changes to this revision.Apr 11 2018, 23:02
schancel added a subscriber: schancel.
schancel added inline comments.
src/secp256k1/Makefile.am
179 ↗(On Diff #3474)

Cruft?

This revision now requires changes to proceed.Apr 11 2018, 23:02
teamcity added a subscriber: teamcity.Apr 11 2018, 23:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix updated this revision to Diff 3475.Apr 11 2018, 23:03
deadalnix removed a subscriber: teamcity.

Remove changes to secp256k1.c

Keep the module inclusion reorder in Makefile.am for consistency.

teamcity added a comment.Apr 11 2018, 23:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel accepted this revision.Apr 11 2018, 23:06
This revision is now accepted and ready to land.Apr 11 2018, 23:06
Closed by commit rABC77507ac86f97: [secp256k1] Fix bench_internal build (authored by deadalnix). · Explain WhyApr 11 2018, 23:06
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 11 2018, 23:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 11 2018, 23:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 11 2018, 23:40

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2293: Diff 3475.Apr 11 2018, 23:40
teamcity added a comment.Apr 11 2018, 23:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2292: Diff 3474.Apr 11 2018, 23:41

Revision Contents
Changeset List

PathSize
src/
secp256k1/
9 lines

Diff 3476

View Options

src/secp256k1/Makefile.am

Loading...