Page MenuHomePhabricator

Fix automated timings updates
ClosedPublic

Authored by Fabien on Dec 8 2022, 16:21.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC00d96f1281ea: Fix automated timings updates
Summary

Chronik needs to be enabled so the chronik_* tests are accounted for.

The USDT tests are not designed to be run as part of a normal test framework run, as they need some extra privileges. As such it makes no sense to store their timing: as soon as the appriated conditions are met, they need to run no matter the duration.
Also exclude them from the automated timing.json update script check for the same reason.

Test Plan
mkdir buildTracing
cmake -GNinja .. -DENABLE_TRACING
ninja
sudo ./test/functional/test_runner.py interface_usdt_net

Check the timing is not written to buildTracing/timings.json

Check it succeeds:

BUILD_DIR=$PWD/../buildTImings ../contrib/source-control-tools/patch-recipes/update-timings.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
timings_no_usdt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21483
Build 42615: Build Diffbuild-debug · build-clang-tidy · build-without-wallet · build-diff · build-clang
Build 42614: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Dec 8 2022, 16:21
This revision is now accepted and ready to land.Dec 8 2022, 17:26
This revision was automatically updated to reflect the committed changes.