Various improvement in the serialization code
ClosedPublic
Actions

Authored by deadalnix on Apr 12 2018, 22:55.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING6c6333c42a12: Various improvement in the serialization code
rABC6c6333c42a12: Various improvement in the serialization code

Summary

Use fixed size types or size_t
Use C++11 style for loops
Use braces consistently

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 12 2018, 22:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2018, 22:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2306: Diff 3491.Apr 12 2018, 23:33

jasonbcox requested changes to this revision.Apr 13 2018, 06:31

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/serialize.h
760 ↗	(On Diff #3491)	Is it possible to do `const auto` here?

This revision now requires changes to proceed.Apr 13 2018, 06:31

Use const auto

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2310: Diff 3498.Apr 13 2018, 13:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Thanks. Lots of good cleanup :)

This revision is now accepted and ready to land.Apr 13 2018, 18:48

Closed by commit rABC6c6333c42a12: Various improvement in the serialization code (authored by deadalnix). · Explain WhyApr 13 2018, 22:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

serialize.h

145 lines

Diff 3499

View Options

Various improvement in the serialization codeClosedPublicActions