Differential D12876

[Cashtab][extension] Fixed positioning of popout button on ext header
AbandonedPublic
Actions

Authored by kieran709 on Dec 12 2022, 22:18.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Related to T2870. Added flex ctn to cashtab logo in the extension to fix issue with the popout button appearing below the logo & nav indicators.

Test Plan

cd web/cashtab && npm run extension
wait for extension to build
in your browser's extension manager:
click load unpacked
navigate to /extension and select the /dist dir
open the extension
observe that the popout button is now flexed with the cashtab logo

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21553
Build 42748: Build Diff	cashtab-tests
Build 42747: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 12 2022, 22:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2022, 22:18

kieran709 requested review of this revision.Dec 12 2022, 22:18

Harbormaster completed remote builds in B21553: Diff 37245.Dec 12 2022, 22:21

This is an improvement, but we want the "open in tab" link to be right-aligned, not center aligned and to the right of Cashtab.

image.png (205×395 px, 13 KB)

This revision now requires changes to proceed.Dec 12 2022, 22:41

kieran709 abandoned this revision.Dec 12 2022, 23:13

bytesofman mentioned this in D12879: [Cashtab][extn] Fix popout button placement.Dec 13 2022, 00:08

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

components/

28 lines

Diff 37245

web/cashtab/extension/src/components/App.js

Loading...