Differential D12896

[avalanche] Cleanup unnecessary timeout values in block voting test
ClosedPublic
Actions

Authored by sdulfari on Dec 14 2022, 19:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3a2eaa578f58: [avalanche] Cleanup unnecessary timeout values in block voting test

Summary

Setting the timeouts here are not necessary and copy-paste is causing them to
creap. Remove all of them. Shorter timeouts when debugging can be achieved
using --timeout-factor.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Dec 14 2022, 19:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2022, 19:40

sdulfari requested review of this revision.Dec 14 2022, 19:40

Harbormaster completed remote builds in B21590: Diff 37309.Dec 14 2022, 19:54

Fabien accepted this revision.Dec 14 2022, 20:00

This revision is now accepted and ready to land.Dec 14 2022, 20:00

Closed by commit rABC3a2eaa578f58: [avalanche] Cleanup unnecessary timeout values in block voting test (authored by sdulfari). · Explain WhyDec 14 2022, 20:42

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC3a2eaa578f58: [avalanche] Cleanup unnecessary timeout values in block voting test.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_voting.py

10 lines

Diff 37314

View Options

test/functional/abc_p2p_avalanche_voting.py

[avalanche] Cleanup unnecessary timeout values in block voting testClosedPublicActions