Page MenuHomePhabricator
Differential D12941

[avalanche] Add the local proof verification status details to getavalancheinfo
ClosedPublic
Actions

Authored by Fabien on Dec 27 2022, 17:23.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC36679016a4f4: [avalanche] Add the local proof verification status details to getavalancheinfo
Summary

The getavalancheinfo RPC returns whether the local proof is verified or not, but gives no indication about why it's not verified. Since the node waits for a block to trigger the verification this can lead to confusion when a user restarts and see his proof being unverified.

This diff adds another status field when the verified field is false to indicate whether the verification is pending or if the verification ocurred but failed.

Test Plan
./test/functional/test_runner.py abc_rpc_getavalancheinfo

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_getavalancheinfo_verified_tristate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21676
Build 42992: Build Difflint-circular-dependencies · build-debug · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 42991: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 27 2022, 17:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 27 2022, 17:23
Fabien requested review of this revision.Dec 27 2022, 17:23
Harbormaster completed remote builds in B21676: Diff 37432.Dec 27 2022, 17:39
Fabien planned changes to this revision.Dec 28 2022, 10:08

There are cases where that info can be wrong, needs to be updated

Fabien updated this revision to Diff 37436.Dec 28 2022, 12:07

Handle all the registration failure cases, add another test case, add a release note

Harbormaster completed remote builds in B21678: Diff 37436.Dec 28 2022, 12:22
Fabien updated this revision to Diff 37438.Dec 29 2022, 12:45

Rebase

Harbormaster completed remote builds in B21679: Diff 37438.Dec 29 2022, 13:01
sdulfari accepted this revision.Dec 29 2022, 21:11
This revision is now accepted and ready to land.Dec 29 2022, 21:11
Closed by commit rABC36679016a4f4: [avalanche] Add the local proof verification status details to getavalancheinfo (authored by Fabien). · Explain WhyDec 30 2022, 09:41
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC36679016a4f4: [avalanche] Add the local proof verification status details to getavalancheinfo.

Revision Contents
Changeset List

PathSize
src/
rpc/
25 lines
test/
functional/
52 lines

Diff 37432

View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_getavalancheinfo.py

Loading...