Page MenuHomePhabricator
Differential D12943

[avalanche] Add test coverage for parking against avalanche finalized chaintip
ClosedPublic
Actions

Authored by sdulfari on Dec 29 2022, 21:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4981f77bb694: [avalanche] Add test coverage for parking against avalanche finalized chaintip
Summary

Ensure we do not introduce regressions related to parking blocks near the chaintip.
With avalanche now enabled by default and validation changes planned, testing this
behavior explicitly is very important.

Test Plan
ninja
./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ava-finalize-test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21680
Build 43000: Build Diffbuild-diff · build-clang · build-debug · build-clang-tidy · build-without-wallet
Build 42999: arc lint + arc unit

Event Timeline

sdulfari created this revision.Dec 29 2022, 21:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 29 2022, 21:26
sdulfari requested review of this revision.Dec 29 2022, 21:26
sdulfari added a child revision: D12944: [avalanche] Improve test coverage of existing parking behavior.Dec 29 2022, 21:35
Harbormaster completed remote builds in B21680: Diff 37439.Dec 29 2022, 21:39
Fabien accepted this revision.Dec 30 2022, 10:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_p2p_avalanche_voting.py
254

That's the same address as above which is confusing, please use ADDRESS_ECREG_UNSPENDABLE

This revision is now accepted and ready to land.Dec 30 2022, 10:02
Closed by commit rABC4981f77bb694: [avalanche] Add test coverage for parking against avalanche finalized chaintip (authored by sdulfari). · Explain WhyDec 30 2022, 23:40
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC4981f77bb694: [avalanche] Add test coverage for parking against avalanche finalized chaintip.

Revision Contents
Changeset List

PathSize
test/
functional/
28 lines

Diff 37439

View Options

test/functional/abc_p2p_avalanche_voting.py

Loading...