Page MenuHomePhabricator

[Cashtab] Make sure snapshot changes are included in code review
ClosedPublic

Authored by bytesofman on Jan 3 2023, 19:28.

Details

Summary

T2890

Changse to snapshots should correspond to changes to the code in any given diff. Hence, changes to snapshot files should be reviewed.

If the snapshot changes are too large to be reviewed, this means the snapshot test itself is poorly designed and should be abandoned or re-engineered.

See jest docs from task link.

Test Plan

npm test
Confirm the command still runs

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable