Page MenuHomePhabricator
Differential D12980

[avalanche] Create a generic vote map that can have any kind of item being voted on
ClosedPublic
Actions

Authored by Fabien on Jan 13 2023, 20:28.

Details

Reviewers
PiRK
sdulfari
Group Reviewers
Restricted Project
Commits
rABCd67474db0eea: [avalanche] Create a generic vote map that can have any kind of item being…
Summary

For now the vote maps are typed, there is one for blocks and one for proofs.
This diff creates a new structure that maps a std::variant so that any kind of type can be added to it. It will be used to factorized and simplify the code when we add transactions to the polls.

This structure is currently unused outside of its unit test.

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 13 2023, 20:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2023, 20:28
Fabien requested review of this revision.Jan 13 2023, 20:28
Harbormaster completed remote builds in B21743: Diff 37533.Jan 13 2023, 20:42
Fabien planned changes to this revision.Jan 14 2023, 10:13
Fabien updated this revision to Diff 37537.Jan 14 2023, 10:39

Rename the type expansion/deduction structure, and use a better way to reverse the block comparator output

Harbormaster completed remote builds in B21746: Diff 37537.Jan 14 2023, 10:56
PiRK requested changes to this revision.Jan 16 2023, 08:12
PiRK added a subscriber: PiRK.

Looks good except for nits

src/avalanche/processor.h
109 ↗(On Diff #37537)

purposes

113 ↗(On Diff #37537)

layout

This revision now requires changes to proceed.Jan 16 2023, 08:12
Fabien updated this revision to Diff 37538.Jan 16 2023, 09:23

Fix typo and layout

Harbormaster completed remote builds in B21747: Diff 37538.Jan 16 2023, 09:38
PiRK accepted this revision.Jan 16 2023, 09:56
This revision is now accepted and ready to land.Jan 16 2023, 09:56
sdulfari accepted this revision.Jan 16 2023, 21:56
Closed by commit rABCd67474db0eea: [avalanche] Create a generic vote map that can have any kind of item being… (authored by Fabien). · Explain WhyJan 17 2023, 08:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd67474db0eea: [avalanche] Create a generic vote map that can have any kind of item being….

Revision Contents
Changeset List

PathSize
src/
avalanche/
43 lines
test/
91 lines

Diff 37549

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...