Differential D12984

Access miner fund destinations by reference in getblocktemplate
ClosedPublic
Actions

Authored by sdulfari on Jan 17 2023, 18:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa331108f3941: Access miner fund destinations by reference in getblocktemplate

Summary

No need to copy. This patch makes it const too.

Test Plan

ninja && ./test/functional/test_runner.py abc_feature_minerfund abc_mining_basic

Diff Detail

Repository

rABC Bitcoin ABC

Branch

const-fund-dest

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21760
Build 43155: Build Diff	build-without-wallet · build-debug · lint-circular-dependencies · build-clang · build-diff · build-clang-tidy
Build 43154: arc lint + arc unit

Event Timeline

sdulfari created this revision.Jan 17 2023, 18:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2023, 18:03

sdulfari requested review of this revision.Jan 17 2023, 18:03

Harbormaster completed remote builds in B21760: Diff 37553.Jan 17 2023, 18:19

Fabien accepted this revision.Jan 17 2023, 19:26

This revision is now accepted and ready to land.Jan 17 2023, 19:26

Closed by commit rABCa331108f3941: Access miner fund destinations by reference in getblocktemplate (authored by sdulfari). · Explain WhyJan 17 2023, 19:33

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABCa331108f3941: Access miner fund destinations by reference in getblocktemplate.

Revision Contents
Changeset List

Path

Size

src/

rpc/

mining.cpp

2 lines

Diff 37553

View Options

Access miner fund destinations by reference in getblocktemplateClosedPublicActions