Now that avalanche is enabled by default the test framework can treat it as
such. It is natural to expect sync_all to sync all inventories, including
proofs.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC0b22e71ce430: [avalanche] Sync proofs when functional tests call sync_all
ninja check-functional
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sync-all-with-proofs
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 21782 Build 43199: Build Diff build-diff · build-debug · build-clang-tidy · build-clang · build-without-wallet Build 43198: arc lint + arc unit
Event Timeline
| test/functional/abc_p2p_avalanche_voting.py | ||
|---|---|---|
| 40 | The alternate approach is to sync_blocks on the two generate() calls that dont have sync_fun set in this test, but that gives a bad code smell because there is no explicit reason to not sync the proofs. The test simply does not rely on them. It is more correct to have the node configs match so that they sync proofs without modifying the test. | |
| test/functional/abc_p2p_proof_inventory.py | ||
|---|---|---|
| 200 | Yes, which is why I introduced sync_fun=self.sync_blocks so that proofs are not explicitly synced between all nodes. | |
| test/functional/abc_rpc_avalancheproof.py | ||
| 193 | The node is started with an immature proof, so while the proof may be sent to peered nodes, sync_proofs only checks getavalanchepeerinfo which shows ava peers. Until the proof matures, it will not appear here. | |