Differential D13013

[avalanche] Build the processor from the node context
AbandonedPublic
Actions

Authored by Fabien on Jan 19 2023, 16:15.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This greatly simplifies building the avalanche processor.

Depends on D13009 and D13011.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_processor_node

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21799
Build 43233: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-diff · build-clang
Build 43232: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 19 2023, 16:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2023, 16:15

Fabien requested review of this revision.Jan 19 2023, 16:15

Harbormaster completed remote builds in B21799: Diff 37602.Jan 19 2023, 16:16

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "avalanche/processor -> node/context -> net_processing -> avalanche/processor" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Fabien planned changes to this revision.Jan 19 2023, 16:28

In the end we want the opposite, i.e. the processor be part of the node so this circular dependency will only get worst