Page MenuHomePhabricator
Differential D13052

rest: reduce LOCK(cs_main) scope in rest_block
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 16:32.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCae8564750efc: rest: reduce LOCK(cs_main) scope in rest_block
Summary

After commit ccd8ef6 (D2979) it is no longer required to hold cs_main when calling ReadBlockFromDisk.

The first commit moves ReadBlockFromDisk outside the lock scope in rest_block, where we can see a huge performance improvement when fetching blocks with multiple threads.

This is a partial backport of core#26308
https://github.com/bitcoin/bitcoin/pull/26308/commits/c75e3d2772b00acc3850f72a8cb733a0345aa773

Test Plan

With Clang and DEBUG:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 24 2023, 16:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 16:32
PiRK requested review of this revision.Jan 24 2023, 16:32
teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 16:32
PiRK added a child revision: D13053: zmq: remove LOCK(cs_main) from NotifyBlock.Jan 24 2023, 16:34
Harbormaster completed remote builds in B21853: Diff 37698.Jan 24 2023, 16:45
sdulfari accepted this revision.Jan 24 2023, 18:15
sdulfari added a subscriber: sdulfari.

reference to prerequisite backport that reduced the cs_main locking: https://reviews.bitcoinabc.org/D2979#change-8J68DPC7df8b

This revision is now accepted and ready to land.Jan 24 2023, 18:15
PiRK edited the summary of this revision. (Show Details)Jan 25 2023, 07:17
Closed by commit rABCae8564750efc: rest: reduce LOCK(cs_main) scope in rest_block (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhyJan 25 2023, 07:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCae8564750efc: rest: reduce LOCK(cs_main) scope in rest_block.
PiRK mentioned this in D18255: net: reduce LOCK(cs_main) scope in GETBLOCKTXN.Jun 14 2025, 14:05
PiRK mentioned this in rABCca505b1524f0: net: reduce LOCK(cs_main) scope in GETBLOCKTXN.Jun 17 2025, 09:20

Revision Contents
Changeset List

PathSize
src/
9 lines

Diff 37714

View Options

src/rest.cpp

Loading...