Page MenuHomePhabricator
Differential D13059

wallet: drop anti-fee-sniping feature, set locktime = 0
ClosedPublic
Actions

Authored by PiRK on Jan 25 2023, 08:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf9ee62b17ab3: wallet: drop anti-fee-sniping feature, set locktime = 0
Summary

Post-consensus mitigates fee-sniping, so we don't need to set a locktime to the current block height when creating a wallet transaction.

This reduces the wallet fingerprintability, as light wallets don't have access to the current block height and cannot set the locktime.

The plan is to disable this feature by default also in Electrum ABC (but keep the option to do it for the sake of splitting coins).

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 25 2023, 08:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2023, 08:59
PiRK requested review of this revision.Jan 25 2023, 08:59
Harbormaster completed remote builds in B21865: Diff 37720.Jan 25 2023, 08:59
PiRK updated this revision to Diff 37721.Jan 25 2023, 09:00

remove unused import

Harbormaster completed remote builds in B21866: Diff 37721.Jan 25 2023, 09:17
Fabien requested changes to this revision.Jan 25 2023, 10:30
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/spend.cpp
611 ↗(On Diff #37721)

You should really had a comment explaining why 0 is the chosen value with a bit of history: why the previous mitigations are no longer relevant and the benefit no longer taking over the privacy decrease. More or less what's is in the summary.

test/functional/wallet_create_tx.py
35 ↗(On Diff #37721)

Please keep some tests for the current behavior otherwise nothing will break upon change of this value and we will never remember why the value was chosen to begin with. Let's quote Antony and not create a Chesterton’s Fence situation :)

This revision now requires changes to proceed.Jan 25 2023, 10:30
PiRK updated this revision to Diff 37722.Jan 25 2023, 11:23

restore the functional test, add comments about why the feature is now disabled.

Harbormaster completed remote builds in B21867: Diff 37722.Jan 25 2023, 11:40
Fabien added inline comments.Jan 25 2023, 12:15
src/wallet/spend.cpp
614 ↗(On Diff #37722)

Please explain that locktime=0 is the easiest solution for the light wallets that have no access to the current block height and so is the best option for privacy.

PiRK updated this revision to Diff 37724.Jan 25 2023, 12:59

explain that locktime = 0 is the easiest choice for light wallets

Fabien accepted this revision.Jan 25 2023, 13:05
This revision is now accepted and ready to land.Jan 25 2023, 13:05
Harbormaster completed remote builds in B21869: Diff 37724.Jan 25 2023, 13:12
Closed by commit rABCf9ee62b17ab3: wallet: drop anti-fee-sniping feature, set locktime = 0 (authored by PiRK). · Explain WhyJan 25 2023, 20:37
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf9ee62b17ab3: wallet: drop anti-fee-sniping feature, set locktime = 0.

Revision Contents
Changeset List

PathSize
src/
wallet/
75 lines
test/
2 lines
test/
functional/
11 lines

Diff 37734

View Options

src/wallet/spend.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

test/functional/wallet_create_tx.py

Loading...