Differential D13083

[explorer] Fix table sorting issues
ClosedPublic
Actions

Authored by johnkuney on Jan 31 2023, 20:19.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCdf34c0f5aa58: [explorer] Fix table sorting issues

Summary

Sorting by column values on the block and address page tables was not working properly for some columns.
The issue was if there was an added suffix like "XEC" or "kB" for example it was breaking the plugin's sorting.
I modified some of the columns rendering functions to use a data attribute instead for displaying the suffixes

Test Plan

run the app and see if sorting works better

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Jan 31 2023, 20:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2023, 20:19

johnkuney requested review of this revision.Jan 31 2023, 20:19

Harbormaster completed remote builds in B21903: Diff 37771.Jan 31 2023, 20:19

Tested it out, sorting is still broken for me

For example address try address ecash:qqm84rstn320x567geqhpu33xlus9vvv458t39tcau and sort by size.... it sorts "1.08 kB" as smaller than "225B"

This revision now requires changes to proceed.Feb 3 2023, 17:00

Adding a type field to the file size columns so they sort properly

Harbormaster completed remote builds in B21935: Diff 37819.Feb 3 2023, 19:46

Good call, should be good now

Sorts properly now

This revision is now accepted and ready to land.Feb 3 2023, 19:55

Closed by commit rABCdf34c0f5aa58: [explorer] Fix table sorting issues (authored by johnkuney). · Explain WhyFeb 6 2023, 23:13

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCdf34c0f5aa58: [explorer] Fix table sorting issues.

Revision Contents
Changeset List

Path

Size

web/

explorer/

explorer-server/

code/

41 lines

42 lines

styles/

14 lines

42 lines

Diff 37833

web/explorer/explorer-server/code/address.js

Loading...

web/explorer/explorer-server/code/common.js

Loading...

web/explorer/explorer-server/code/styles/index.css

Loading...

web/explorer/explorer-server/code/txs.js

Loading...