Page MenuHomePhabricator

[avalanche] Disable test framework default proof expiry
ClosedPublic

Authored by sdulfari on Feb 23 2023, 01:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC683173751045: [avalanche] Disable test framework default proof expiry
Summary

For picking test timestamps "far in the future", it is natural to grab the
current timestamp, increment the most signficant digit and zero out the rest.
Until 2033 that process results in 2000000000.

The current test framework default proof expiry just happens to be this time
and so do various activation times that we tend to use. This is bad because
it leads to unnecessary debugging that could have been avoided with a good
default. And if you are really unlucky, other issues make that debugging
experience much worse: D13160

abc_rpc_getavalancheinfo.py has been modified because it depends on some
non-zero expiry for the test.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Feb 23 2023, 11:03
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/avatools.py
398–410 ↗(On Diff #38004)

Let's avoid the code duplication

This revision now requires changes to proceed.Feb 23 2023, 11:03
This revision is now accepted and ready to land.Feb 23 2023, 17:28