Page MenuHomePhabricator
Differential D13160

[avalanche] Log when a proof becomes invalid
ClosedPublic
Actions

Authored by sdulfari on Feb 23 2023, 00:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb472229476e8: [avalanche] Log when a proof becomes invalid
Summary

This is useful in a lot of cases, especially when a proof expires.

Especially acute in the test environment where many proofs may have the same
expiry for convenience. I learned the hard way that proofs unexpectedly
expiring leads to no other clues in the logs other than simply not polling.

[../src/avalanche/peermanager.cpp:501] [updatedBlockTip] Peer proof 37011d056427f4639c80dc3df324fcfe26d98f8ffb6b12a016d52a6d37e9d0ef verification failed (expired-proof)

Test Plan
ninja && ./test/functional/test_runner.py --nocleanup abc_rpc_getavalancheinfo

Log appears like this:

[../src/avalanche/peermanager.cpp:500] [updatedBlockTip] Invalidating proof 70d67e4e03555ade4f40944236703e076e04b8ddb4fb5c9c10cc871667e7efa8: verification failed (expired-proof)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.Feb 23 2023, 00:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 23 2023, 00:22
sdulfari requested review of this revision.Feb 23 2023, 00:22
Harbormaster completed remote builds in B22059: Diff 38003.Feb 23 2023, 00:35
sdulfari mentioned this in D13161: [avalanche] Disable test framework default proof expiry.Feb 23 2023, 01:02
Fabien accepted this revision.Feb 23 2023, 11:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/peermanager.cpp
499 ↗(On Diff #38003)
This revision is now accepted and ready to land.Feb 23 2023, 11:00
sdulfari updated this revision to Diff 38011.Feb 23 2023, 16:35

feedback

sdulfari edited the test plan for this revision. (Show Details)Feb 23 2023, 16:36
Harbormaster completed remote builds in B22065: Diff 38011.Feb 23 2023, 16:52
Closed by commit rABCb472229476e8: [avalanche] Log when a proof becomes invalid (authored by sdulfari). · Explain WhyFeb 23 2023, 16:57
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABCb472229476e8: [avalanche] Log when a proof becomes invalid.
sdulfari mentioned this in rABC683173751045: [avalanche] Disable test framework default proof expiry.Feb 23 2023, 18:28

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines

Diff 38013

View Options

src/avalanche/peermanager.cpp

Loading...