Page MenuHomePhabricator

[avalanche] Cleanup unnecessary API passthrough of getWinners
ClosedPublic

Authored by roqqit on Wed, Apr 2, 18:53.

Details

Summary

Consolidate the logic for determining the new stake winners in peerManager. This makes it more clear that winners should be updated every time a contender is finalized via avalanche and eliminates the API passthrough to getWinners, which is unnecessary.

Depends on D17881

Test Plan
ninja && ninja check && ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

roqqit requested review of this revision.Wed, Apr 2, 18:53
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/processor.cpp
1074 ↗(On Diff #53336)

should not be necessary, but belt and suspenders

This revision is now accepted and ready to land.Wed, Apr 2, 21:09