Page MenuHomePhabricator
Differential D17882

[avalanche] Cleanup unnecessary API passthrough of getWinners
ClosedPublic
Actions

Authored by roqqit on Wed, Apr 2, 18:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCee751ff92ab4: [avalanche] Cleanup unnecessary API passthrough of getWinners
Summary

Consolidate the logic for determining the new stake winners in peerManager. This makes it more clear that winners should be updated every time a contender is finalized via avalanche and eliminates the API passthrough to getWinners, which is unnecessary.

Depends on D17881

Test Plan
ninja && ninja check && ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sc-cleanup-finalizecontender
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32876
Build 65237: Build Diffbuild-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 65236: arc lint + arc unit

Event Timeline

roqqit created this revision.Wed, Apr 2, 18:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 2, 18:53
roqqit requested review of this revision.Wed, Apr 2, 18:53
Harbormaster completed remote builds in B32876: Diff 53336.Wed, Apr 2, 19:08
Fabien accepted this revision.Wed, Apr 2, 21:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/processor.cpp
1074

should not be necessary, but belt and suspenders

This revision is now accepted and ready to land.Wed, Apr 2, 21:09
Closed by commit rABCee751ff92ab4: [avalanche] Cleanup unnecessary API passthrough of getWinners (authored by roqqit). · Explain WhyWed, Apr 2, 23:46
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABCee751ff92ab4: [avalanche] Cleanup unnecessary API passthrough of getWinners.

Revision Contents
Changeset List

PathSize
src/
avalanche/
7 lines
17 lines
20 lines

Diff 53336

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.cpp

Loading...