Differential D13168

Remove unused block height in mempool removeForBlock
ClosedPublic
Actions

Authored by Fabien on Feb 24 2023, 17:39.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC29e9d48bb254: Remove unused block height in mempool removeForBlock

Summary

As per title, there is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_unused_blockheight

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22080
Build 43795: Build Diff	build-without-wallet · build-diff · lint-circular-dependencies · build-debug · build-clang-tidy · build-clang
Build 43794: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 24 2023, 17:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 24 2023, 17:39

Fabien requested review of this revision.Feb 24 2023, 17:39

Harbormaster completed remote builds in B22080: Diff 38032.Feb 24 2023, 17:56

sdulfari accepted this revision.Feb 24 2023, 17:59

This revision is now accepted and ready to land.Feb 24 2023, 17:59

Closed by commit rABC29e9d48bb254: Remove unused block height in mempool removeForBlock (authored by Fabien). · Explain WhyFeb 24 2023, 18:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC29e9d48bb254: Remove unused block height in mempool removeForBlock.

Revision Contents
Changeset List

Path

Size

src/

test/

mempool_tests.cpp

2 lines

policyestimator_tests.cpp

4 lines

txmempool.h

4 lines

txmempool.cpp

3 lines

validation.cpp

2 lines

Diff 38032

View Options

src/test/mempool_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

Remove unused block height in mempool removeForBlockClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38032

src/test/mempool_tests.cpp

src/test/policyestimator_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.cpp

Remove unused block height in mempool removeForBlock
ClosedPublic
Actions

Revision Contents
Changeset List