interface_bitcoin_cli.py
ClosedPublic
Actions

Authored by PiRK on Feb 28 2023, 09:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC561d29d991c2: test: resolve bug in test/functional/interface_bitcoin_cli.py

Summary

The test "Test -getinfo with -rpcwallet=unloaded wallet returns no balances" was not actually asserting anything useful as cli_get_info_keys was not defined and was reused from an earlier test instead.

This is a backport of core#21822

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 28 2023, 09:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2023, 09:46

PiRK requested review of this revision.Feb 28 2023, 09:46

teamcity edited the summary of this revision. (Show Details)Feb 28 2023, 09:46

Fabien accepted this revision.Feb 28 2023, 10:04

This revision is now accepted and ready to land.Feb 28 2023, 10:04

Harbormaster completed remote builds in B22124: Diff 38093.Feb 28 2023, 10:06

Closed by commit rABC561d29d991c2: test: resolve bug in test/functional/interface_bitcoin_cli.py (authored by klementtan <klement.tan@ninjavan.co>, committed by PiRK). · Explain WhyFeb 28 2023, 10:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC561d29d991c2: test: resolve bug in test/functional/interface_bitcoin_cli.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

interface_bitcoin_cli.py

3 lines

Diff 38095

View Options

test/functional/interface_bitcoin_cli.py

test: resolve bug in test/functional/interface_bitcoin_cli.pyClosedPublicActions