refactor, net: Relocate CNode private members and increase data member encapsulation
ClosedPublic
Actions

Authored by PiRK on Mar 10 2023, 15:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfaefb62eb651: refactor, net: Relocate CNode private members and increase data member…

Summary

All protected CNode data members could be private.

This is a backport of core#20373

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 10 2023, 15:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 10 2023, 15:06

PiRK requested review of this revision.Mar 10 2023, 15:06

teamcity edited the summary of this revision. (Show Details)Mar 10 2023, 15:06

Harbormaster completed remote builds in B22327: Diff 38396.Mar 10 2023, 15:37

Fabien accepted this revision.Mar 10 2023, 15:51

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net.h
844 ↗	(On Diff #38396)	could be moved above

This revision is now accepted and ready to land.Mar 10 2023, 15:51

move mutex above guarded var

Harbormaster completed remote builds in B22328: Diff 38397.Mar 10 2023, 17:04

Closed by commit rABCfaefb62eb651: refactor, net: Relocate CNode private members and increase data member… (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMar 13 2023, 07:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfaefb62eb651: refactor, net: Relocate CNode private members and increase data member….

Revision Contents
Changeset List

Path

Size

src/

net.h

93 lines

Diff 38475

View Options

refactor, net: Relocate CNode private members and increase data member encapsulationClosedPublicActions