Page MenuHomePhabricator

[Cashtab] [Alias] - Alias address preview upon valid input
ClosedPublic

Authored by emack on Mar 11 2023, 14:04.

Details

Summary

T2989

Upon input of a valid alias in send xec and send token components, the parsed address is displayed beneath the address input as a preview for the user for verification purposes.

Test Plan
  • navigate to Send, input a valid alias and ensure the address preview message is displayed This alias resolves to...
  • add one extra character to invalidate the alias input and ensure the address preview is cleared and Invalid address is displayed
  • remove the one extra character from above and ensure address preview is displayed again
  • replace the alias input with a valid ecash address and ensure no address preview nor error is displayed
  • use an invalid ecash address and ensure Invalid address is displayed
  • enter a valid alias and send a normal XEC transaction. Ensure upon successful broadcast the address preview message is cleared
  • repeat the above for sendToken

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Mar 11 2023, 14:04

Looks good. Just a copy change.

web/cashtab/src/components/Send/Send.js
786 ↗(On Diff #38437)

I don't think we need to spell it out so hard. Just including ${aliasInputAddress.slice...} is enough, remove "This alias resolves to "

This revision now requires changes to proceed.Mar 11 2023, 18:13

Shortened alias address preview for both Send and SendToken components

This revision is now accepted and ready to land.Mar 12 2023, 22:04