Page MenuHomePhabricator
Differential D13307

[Cashtab] [Alias] Hyperlink the alias address preview
ClosedPublic
Actions

Authored by emack on Mar 13 2023, 11:48.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCff9b66756476: [Cashtab] [Alias] Hyperlink the alias address preview
Summary

T2994

Turn the alias address preview into a hyperlink on both send and sendToken screens.

Test Plan
  • enable Alias in ticker.js
  • enter a valid alias in send, click on the rendered hyperlink and ensure a new window is opened containing the address via explorer
  • enter a valid alias in sendToken, click on the rendered hyperlink and ensure a new window is opened containing the address via explorer
  • ensure no regression to invalid aliases, valid ecash addresses and invalid ecash addresses

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack created this revision.Mar 13 2023, 11:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 13 2023, 11:48
emack requested review of this revision.Mar 13 2023, 11:48
Harbormaster completed remote builds in B22399: Diff 38490.Mar 13 2023, 12:04
bytesofman requested changes to this revision.Mar 13 2023, 17:12
bytesofman added inline comments.
web/cashtab/src/components/Send/Send.js
52 ↗(On Diff #38490)

Since TxLink appears in two components, it should be in its own file and imported here. Throw it in /common/Atoms.js

This revision now requires changes to proceed.Mar 13 2023, 17:12
emack updated this revision to Diff 38526.Mar 14 2023, 02:55
emack marked an inline comment as done.

Moved TxLink to Atoms

Harbormaster completed remote builds in B22420: Diff 38526.Mar 14 2023, 02:57
bytesofman accepted this revision.Mar 14 2023, 03:48
This revision is now accepted and ready to land.Mar 14 2023, 03:48
Closed by commit rABCff9b66756476: [Cashtab] [Alias] Hyperlink the alias address preview (authored by emack). · Explain WhyMar 14 2023, 04:12
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCff9b66756476: [Cashtab] [Alias] Hyperlink the alias address preview.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Airdrop/
__tests__/
__snapshots__/
50 lines
Alias/
__tests__/
__snapshots__/
102 lines
Common/
4 lines
Configure/
__tests__/
__snapshots__/
44 lines
Home/
__tests__/
__snapshots__/
96 lines
Receive/
__tests__/
__snapshots__/
58 lines
Send/
22 lines
21 lines
__tests__/
__snapshots__/
225 lines
15 lines
SignVerifyMsg/
__tests__/
__snapshots__/
96 lines
Tokens/
__tests__/
__snapshots__/
14 lines
88 lines

Diff 38530

View Options

web/cashtab/src/components/Airdrop/__tests__/__snapshots__/Airdrop.test.js.snap

Loading...
View Options

web/cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap

Loading...
View Options

web/cashtab/src/components/Common/Atoms.js

Loading...
View Options

web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

Loading...
View Options

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

web/cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/components/Send/SendToken.js

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap

Loading...
View Options

web/cashtab/src/components/SignVerifyMsg/__tests__/__snapshots__/SignVerifyMsg.test.js.snap

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/CreateTokenForm.test.js.snap

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

Loading...