Paths

Table of Contentst

Differential D1333

[cmake] Improve the way BerkeleyDB++ is looked for and used.
ClosedPublic
Actions

Authored by deadalnix on May 1 2018, 15:20.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING2e059ee43151: [cmake] Improve the way BerkeleyDB++ is looked for and used.
rABC2e059ee43151: [cmake] Improve the way BerkeleyDB++ is looked for and used.

Summary

As per title.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 1 2018, 15:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2018, 15:20

schancel requested changes to this revision.May 1 2018, 15:21

schancel added a subscriber: schancel.

schancel added inline comments.

cmake/modules/FindBerkeleyDB.cmake
11 ↗	(On Diff #3656)	This needs to just be `db_cxx.h` or it finds some random system garbage.

This revision now requires changes to proceed.May 1 2018, 15:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Actually split header search

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel accepted this revision.May 1 2018, 15:36

This revision is now accepted and ready to land.May 1 2018, 15:36

Harbormaster completed remote builds in B2418: Diff 3656.May 1 2018, 15:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2419: Diff 3657.May 1 2018, 15:45

Closed by commit rABC2e059ee43151: [cmake] Improve the way BerkeleyDB++ is looked for and used. (authored by deadalnix). · Explain WhyMay 1 2018, 16:23

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

FindBerkeleyDB.cmake

23 lines

src/

wallet/

CMakeLists.txt

4 lines

Diff 3661

View Options

cmake/modules/FindBerkeleyDB.cmake