p2p: pass strings to NetPermissions::TryParse functions by const ref
ClosedPublic
Actions

Authored by PiRK on Mar 14 2023, 14:41.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC03266d53e72f: p2p: pass strings to NetPermissions::TryParse functions by const ref

Summary

these are "in" params that are not cheap to copy.

This is a backport of core#21996

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 14 2023, 14:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2023, 14:41

PiRK requested review of this revision.Mar 14 2023, 14:41

teamcity edited the summary of this revision. (Show Details)Mar 14 2023, 14:41

Harbormaster completed remote builds in B22449: Diff 38573.Mar 14 2023, 15:17

sdulfari accepted this revision.Mar 14 2023, 16:19

This revision is now accepted and ready to land.Mar 14 2023, 16:19

Closed by commit rABC03266d53e72f: p2p: pass strings to NetPermissions::TryParse functions by const ref (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyMar 14 2023, 16:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC03266d53e72f: p2p: pass strings to NetPermissions::TryParse functions by const ref.

Revision Contents
Changeset List

Path

Size

src/

net_permissions.h

8 lines

net_permissions.cpp

8 lines

Diff 38576

View Options

src/net_permissions.h