HomePhabricator

p2p: pass strings to NetPermissions::TryParse functions by const ref

Description

p2p: pass strings to NetPermissions::TryParse functions by const ref

Summary:
these are "in" params that are not cheap to copy.

This is a backport of core#21996

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D13335

Details

Provenance
Jon Atack <jon@atack.com>Authored on May 19 2021, 17:26
PiRKCommitted on Mar 14 2023, 16:53
PiRKPushed on Mar 14 2023, 16:53
Reviewer
Restricted Project
Differential Revision
D13335: p2p: pass strings to NetPermissions::TryParse functions by const ref
Parents
rABCee83e416fb31: [Chronik] Require at least Protobuf 3.0.0 for Chronik functional tests
Branches
Unknown
Tags
Unknown