Change time variable type to std::chrono::seconds in src/net_processing.cpp
ClosedPublic
Actions

Authored by PiRK on Mar 17 2023, 15:21.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC053cfdbea441: Change time variable type to std::chrono::seconds in src/net_processing.cpp

Summary

This changes some of the remaining time variable in net_processing.cpp from int64_t to std::chrono. The PR description claims to change all the remaining variables in net_processing, but more are done in follow-up PR 23832

This is a backport of core#23801

It also includes commit https://github.com/bitcoin/bitcoin/pull/21562/commits/a28bfd1d4cfa523a6abf3832dbfd6183cd546944

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 17 2023, 15:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 15:21

PiRK requested review of this revision.Mar 17 2023, 15:21

teamcity edited the summary of this revision. (Show Details)Mar 17 2023, 15:21

PiRK edited the summary of this revision. (Show Details)Mar 17 2023, 15:21

PiRK added a child revision: D13375: Refactor: Changes remaining time variable type from int to chrono.Mar 17 2023, 15:23

PiRK added inline comments.Mar 17 2023, 15:23

src/net_processing.cpp
84 ↗	(On Diff #38672)	This one is addressed in D13375

Harbormaster completed remote builds in B22518: Diff 38672.Mar 17 2023, 15:36

sdulfari accepted this revision.Mar 17 2023, 19:39

This revision is now accepted and ready to land.Mar 17 2023, 19:39

Closed by commit rABC053cfdbea441: Change time variable type to std::chrono::seconds in src/net_processing.cpp (authored by Shashwat <svangani239@gmail.com>, committed by PiRK). · Explain WhyMar 20 2023, 07:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC053cfdbea441: Change time variable type to std::chrono::seconds in src/net_processing.cpp.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

39 lines

Diff 38707

View Options

Change time variable type to std::chrono::seconds in src/net_processing.cppClosedPublicActions