[net processing] Default initialize recentRejects
ClosedPublic
Actions

Authored by PiRK on Mar 17 2023, 15:45.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC934abfb5ff0b: [net processing] Default initialize recentRejects

Summary

Now that recentRejects is owned by PeerManagerImpl, and
PeerManagerImpl's lifetime is managed by the node context, we can just
default initialize recentRejects during object initialization. We can
also remove the unique_ptr indirection.

This is a partial backport of core#21562
https://github.com/bitcoin/bitcoin/pull/21562/commits/cd9902ac5054c01228d52616bf85f7196364d4ff

Depends on D13377

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 17 2023, 15:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 15:45

PiRK requested review of this revision.Mar 17 2023, 15:45

teamcity edited the summary of this revision. (Show Details)Mar 17 2023, 15:45

PiRK added a child revision: D13379: scripted-diff: Rename recentRejects.Mar 17 2023, 15:46

Harbormaster completed remote builds in B22522: Diff 38676.Mar 17 2023, 15:59

sdulfari accepted this revision.Mar 17 2023, 19:24

This revision is now accepted and ready to land.Mar 17 2023, 19:24

Closed by commit rABC934abfb5ff0b: [net processing] Default initialize recentRejects (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyMar 21 2023, 06:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC934abfb5ff0b: [net processing] Default initialize recentRejects.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

23 lines

Diff 38726

View Options

[net processing] Default initialize recentRejectsClosedPublicActions