Differential D13401

More block template creation simplifications
ClosedPublic
Actions

Authored by Fabien on Mar 21 2023, 13:07.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC22e23cf537c1: More block template creation simplifications

Summary

This is a small refactor that makes the code easier to reason about by limiting the use of iterators. This causes less dereferences (the code is easier to read) and allow for a mapTx lookup removal.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 21 2023, 13:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2023, 13:07

Fabien requested review of this revision.Mar 21 2023, 13:07

Harbormaster completed remote builds in B22565: Diff 38732.Mar 21 2023, 13:31

sdulfari accepted this revision.Mar 21 2023, 16:05

This revision is now accepted and ready to land.Mar 21 2023, 16:05

Closed by commit rABC22e23cf537c1: More block template creation simplifications (authored by Fabien). · Explain WhyMar 22 2023, 09:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC22e23cf537c1: More block template creation simplifications.

Revision Contents
Changeset List

Path

Size

src/

node/

miner.cpp

60 lines

Diff 38761

View Options

More block template creation simplificationsClosedPublicActions