Page MenuHomePhabricator
Differential D13434

Fix chronik with no IPv6
ClosedPublic
Actions

Authored by Fabien on Mar 23 2023, 06:14.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCd4c4587a81d4: Fix chronik with no IPv6
Summary

The whole test test_framework assumes that IPv6 might be disabled, but
chronik binds to ::1 by default which will cause the tests to fail.
Also the chronik_serve test checks for IPv6 support before testing the
connection, but not before binding.
This diff fixes both by moving the IPv6 support check and disabling the
IPv6 binding by default.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 23 2023, 06:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2023, 06:14
Fabien requested review of this revision.Mar 23 2023, 06:14
Harbormaster completed remote builds in B22610: Diff 38783.Mar 23 2023, 06:33
PiRK accepted this revision.Mar 23 2023, 10:40
This revision is now accepted and ready to land.Mar 23 2023, 10:40
Closed by commit rABCd4c4587a81d4: Fix chronik with no IPv6 (authored by Fabien). · Explain WhyMar 23 2023, 12:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd4c4587a81d4: Fix chronik with no IPv6.

Revision Contents
Changeset List

PathSize
test/
functional/
10 lines
test_framework/
1 line

Diff 38792

View Options

test/functional/chronik_serve.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...