Differential D13451

[cmake] Don't select an alternative linker for the native build
ClosedPublic
Actions

Authored by Fabien on Mar 24 2023, 08:38.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe383d99abbf4: [cmake] Don't select an alternative linker for the native build

Summary

This non-default linker selection (either gold or lld) is not enforced during cross compilation, and can be easily overriden for standard build.
However there is an exception to this rule: during cross-compilation, the automatic selection applies for the native (host) builds. If the host has no gold/lld installed this could cause the native build to fail.

Test Plan

ninja

Run a cross build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 24 2023, 08:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2023, 08:38

Fabien requested review of this revision.Mar 24 2023, 08:38

@bot build-linux64

teamcity awarded a token.Mar 24 2023, 08:39

Harbormaster completed remote builds in B22642: Diff 38822.Mar 24 2023, 09:09

PiRK accepted this revision.Mar 24 2023, 09:23

This revision is now accepted and ready to land.Mar 24 2023, 09:23

Closed by commit rABCe383d99abbf4: [cmake] Don't select an alternative linker for the native build (authored by Fabien). · Explain WhyMar 24 2023, 09:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe383d99abbf4: [cmake] Don't select an alternative linker for the native build.

Revision Contents
Changeset List

Path

Size

src/

1 line

Diff 38827

src/CMakeLists.txt

Loading...