Differential D13470

[depends] Don't build shared libs in native protobuf
ClosedPublic
Actions

Authored by Fabien on Mar 27 2023, 07:53.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC8039ccfa0512: [depends] Don't build shared libs in native protobuf

Summary

The native protobuf build has been migrated to support cmake (which is available with the new protobuf versions) but the configuration option for disabling the shared libraries has not been ported over and still uses the previous syntax.

Test Plan

Run the gitian builds.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

native_protobuf_cmake

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22711
Build 45042: Build Diff
Build 45041: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 27 2023, 07:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2023, 07:53

Harbormaster completed remote builds in B22711: Diff 38907.Mar 27 2023, 07:53

@bot gitian-linux gitian-osx gitian-win

teamcity awarded a token.Mar 27 2023, 07:53

Fabien published this revision for review.Mar 27 2023, 12:52

sdulfari accepted this revision.Mar 27 2023, 15:57

This revision is now accepted and ready to land.Mar 27 2023, 15:57

Closed by commit rABC8039ccfa0512: [depends] Don't build shared libs in native protobuf (authored by Fabien). · Explain WhyMar 28 2023, 20:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8039ccfa0512: [depends] Don't build shared libs in native protobuf.

Revision Contents
Changeset List

Path

Size

depends/

packages/

native_protobuf.mk

5 lines

Diff 38907

View Options

depends/packages/native_protobuf.mk

[depends] Don't build shared libs in native protobufClosedPublicActions