Page MenuHomePhabricator
Differential D13488

[Chronik] Fix: `tx_writer.insert` in `handle_block_disconnected`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 28 2023, 13:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC41376b0b9781: [Chronik] Fix: `tx_writer.insert` in `handle_block_disconnected`
Summary

chronik_tx didn't include a test for when a block gets removed. This allowed an undetected oversight to slip in: When disconnecting a block, instead of removing txs from the tx index, we would add them.

This fixes it and adds a test to handle this case.

Test Plan

ninja && ./test/functional/test_runner.py chronik_tx

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Mar 28 2023, 13:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2023, 13:33
tobias_ruck requested review of this revision.Mar 28 2023, 13:33
Harbormaster completed remote builds in B22791: Diff 38998.Mar 28 2023, 13:51
Fabien accepted this revision.Mar 28 2023, 21:01
Fabien added inline comments.
chronik/chronik-indexer/src/indexer.rs
276 ↗(On Diff #38998)

Macro lolfail:

This revision is now accepted and ready to land.Mar 28 2023, 21:01
Closed by commit rABC41376b0b9781: [Chronik] Fix: `tx_writer.insert` in `handle_block_disconnected` (authored by tobias_ruck). · Explain WhyMar 28 2023, 21:57
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC41376b0b9781: [Chronik] Fix: `tx_writer.insert` in `handle_block_disconnected`.

Revision Contents
Changeset List

PathSize
chronik/
chronik-indexer/
src/
2 lines
test/
functional/
8 lines

Diff 39006

View Options

chronik/chronik-indexer/src/indexer.rs

Loading...
View Options

test/functional/chronik_tx.py

Loading...